Skip to content

[不是BUG] fix: Fix not determined to be supported the trigger by the handler when undeploy trigger#5185

Closed
wangliang181230 wants to merge 1 commit into
1Panel-dev:v2from
wangliang181230:PR/fix-5
Closed

[不是BUG] fix: Fix not determined to be supported the trigger by the handler when undeploy trigger#5185
wangliang181230 wants to merge 1 commit into
1Panel-dev:v2from
wangliang181230:PR/fix-5

Conversation

@wangliang181230
Copy link
Copy Markdown
Contributor

What this PR does / why we need it?

fix; Fix not determined to be supported the trigger by the handler when undeploy trigger

Summary of your change

修复取消部署触发器时,未判断处理器是否支持该触发器的问题。

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented Apr 27, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented Apr 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangliang181230 wangliang181230 force-pushed the PR/fix-5 branch 2 times, most recently from 28e2725 to 1e98b37 Compare April 30, 2026 07:26
@liuruibin
Copy link
Copy Markdown
Member

liuruibin commented May 21, 2026

这里没有问题,不同类型都会对undeploy有处理

@wangliang181230 wangliang181230 deleted the PR/fix-5 branch May 21, 2026 07:15
@wangliang181230 wangliang181230 changed the title fix: Fix not determined to be supported the trigger by the handler when undeploy trigger [不是BUG] fix: Fix not determined to be supported the trigger by the handler when undeploy trigger May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants